Hi! On Feb 12, Honza Horak wrote: >> grep -q '!includedir /etc/my.cnf.d' /etc/my.cnf || \ >> (echo; echo '!includedir /etc/my.cnf.d') >> /etc/my.cnf > > Thanks for that idea. It would work, but honestly I'm not sure if we > want touch my.cnf during update. I've shared this idea with other > fedora developers to collect their opinions -- feel free to join the > discussion at: > > http://lists.fedoraproject.org/pipermail/devel/2013-February/178475.html So, here I am, replying... On Feb 12, Reindl Harald wrote > any real used mysqld will have a customized /etc/my.cnf and no admin > should do this migartion without take really care what happens and > test this before - unclean soltutions will hurt sooner or later > in moments where this is not expected The solution in my email was clean, as far as I could see. /etc/my.cnf.d directory is empty in our packages (there are files in it, but they contist of comment lines only), so it cannot break anything if added to my.cnf On Feb 12, Toshio Kuratomi wrote > There are several reasons that user's config files shouldn't be touched: > > * Possibility of getting the change to the user's config wrong is very high > as user's can change their config in arbitrary ways. Do you handle the > case where a user has added their own includedirs? Do you handle the case > where a user has commented out their own includedir? Do you handle the > case where a user has a comment about includedir? Do you handle the case > where a user has deleted the includedir line? There are many corner cases > that can be missed here. Yes, it handles the case where a user has added his own includedirs. Yes, it handles the case where a user has commented out his own includedir. Yes, it handles the case where a user has a comment about includedir. Yes and no. If the user has deleted the includedir line, it will be added back. It is, probably, not what the user wants [thus "no"], but achieves exactly the same effect as the other proposed solution (automatically read files in /etc/my.cnf.d/ no matter what's in /etc/my.cnf) [thus "yes"] > * User expectation is currently that their configs aren't going to change on > version upgrade. Instead, they need to look for .rpmnew and .rpmsave > files to tell them if anything has changed that they need to be aware of. > A user updating to F19 won't be expecting that files in /etc/my.cnf.d > should affect their installation if they didn't have to migrate that over > from the my.cnf.rpmnew file themselves. Okay, so you suggest to do nothing - neither append the includedir line to the existing my.cnf nor let mariadb read /etc/my.cnf.d/ automatically and implicitly. That's fine :) I was only trying to find an alternative to "let mariadb read /etc/my.cnf.d implicitly" - because I don't like an idea of adding more magic to the server, it has more than enough of it already. Regards, Sergei -- MariaDB.org -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
