On Fri, Oct 28, 2011 at 7:36 AM, P J P <pj.pandit@xxxxxxxxxxx> wrote: > Hi, > > Please see these review requests, > > > PDFCrack -> https://bugzilla.redhat.com/show_bug.cgi?id=746754 > > ndjbdns -> https://bugzilla.redhat.com/show_bug.cgi?id=480724 > > Could someone approve these packages please? I've just made some comments for PFDCrack, I'll take it once you've made the updates. As for ndjbdns, I'm not quite comfortable with that one. Although I hate to mention it because it looks like so much work has already been done, I will make one recommendation for it. You probably need to create systemd unit files for the tools since it is the default as of F15. You can use some %if logic in the spec to use one spec file for all releases, i.e.: "%if 0%{?fedora} > 14 ..." Richard -- devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/devel
