Jesse Keating wrote:
> There is a slight wrinkle in that right now, the bodhi code will
> automatically request a push of an item that reaches this karma threshold,
> and I don't believe there is a way yet to force it to wait for even
> greater amounts of karma. I believe that fine grained tuning of karma
> automation is planned for the next major version (and rewrite) of bodhi.
That's not a "slight wrinkle", that's a fatal showstopper which means this
change should never have hit production. I consider it completely
unacceptable for my updates to get promoted to stable when I didn't request
it (e.g. I disable karma automatism for all my updates).
The way the workflow should work (*) is that:
* case 1: The maintainer requests the push to stable before the promotion is
approved. Then it will get withheld until approval. Once approval is
obtained, the push is automatically requested by Bodhi.
* case 2: The approval happens before a push to stable is requested. In that
case, the update is marked as approved and the maintainer can queue it to
stable at any time.
That's the only sane way to handle such approval, everything else is just
plain broken. (And isn't that how the security team approval works now? Why
is the proventester approval implemented differently?)
(*) under the (bad) assumption that this process makes sense at all, of
course
Kevin Kofler
--
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel
