Heads-Up: Beware of xmlCleanupParser() when your package links against libxml2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Heya!

if you have code that links against libxml2 and calls
xmlCleanupParser() please verify that your project does that at the
appropriate place (i.e. immediately before exiting, and only once).

That function might delete TLS fields that belong to other libraries
(such as PA's client libs) if called twice. To the effect that PA
might look bad. And I don't like that.

So, please: if you have a library linking against libxml2, verify that
xmlCleanupParser() is called at the appropriate places and only once.

For now at least Empathy and Abiword are calling this function where
they shouldn't, but a google code search reveals that at least
inkscape and dia do it too. I stopped looking after that,
extrapolating that this means "everyone is doing this worng". Hence
this mail.

For more information see:

https://bugzilla.redhat.com/show_bug.cgi?id=554903
http://git.gnome.org/browse/libxml2/tree/parser.c#n14002

I also asked that libxml2 warns directly about this misuse:

https://bugzilla.redhat.com/show_bug.cgi?id=554903

Thanks to Michal Schmidt for tracking this down. 

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4
-- 
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]
  Powered by Linux