On Mon, Apr 06, 2009 at 02:43:41PM +0200, Adam Tkac wrote: > On Mon, Apr 06, 2009 at 10:06:45AM +0100, Tim Waugh wrote: > > On 04/04/2009 08:58 PM, Kevin Kofler wrote: > >> Rawhide Report wrote: > >>> tigervnc-0.0.90-0.3.1.20090403svn3751.fc11 > >>> ------------------------------------------ > >>> * Fri Apr 03 2009 Adam Tkac<atkac redhat com> > >>> 0.0.90-0.4.20090403svn3751 > >> [snip] > >>> - use built-in libjpeg (SSE2/MMX accelerated encoding on x86 platform) > >> > >> Shouldn't this be added to the system libjpeg instead, so all programs > >> benefit? > > > > Not only that but security updates for JPEG implementation flaws will > > require vnc updates as well. > > Right you are, get that improvements to upstream will be the best > solution. Unfortunately no upstream for libjpeg is active so we can't > share TigerVNC code easily. That is still not a reason to put these changes in the VNC codebase. If we're going to carry custom patches anyway, we should put them in the main libjpeg Fedora RPM. > There were no security issue in libjpeg for ten years (please fix me > if I'm incorrect) so I don't think that vnc will suffer due builtin > jpeg. As written on > http://www.mail-archive.com/tigervnc-devel@xxxxxxxxxxxxxxxxxxxxx/msg00225.html > TigerVNC consumes approximately 40% less CPU when it uses builtin jpeg > so it is a valid reason, I think. If they were in the main libjpeg, then every application using libjpeg in Fedora could benefit from this improvement. 40% speed up is very appealing for people working with large photos in jpeg format. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- fedora-devel-list mailing list fedora-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-devel-list
