On Thu, 26 Feb 2004, Michael Schwendt wrote: > On Thu, 26 Feb 2004 21:37:53 +0100 (CET), Dag Wieers wrote: > > > > Let me add my bit of QA: please fix your rpm2html package. > > > You don't know what's wrong? Then get inspiration here: > > > > I don't know what's wrong except that I have an older version and missing > > BuildRequires (which I don't think matters that much). > > Your %install section is completely broken in the for-loop, for instance. > Most likely because you've taken over the spec from somewhere without > reviewing it. Ah, I didn't see that because it wasn't needed anymore. Thanks for making that clear now that's not needed. I'm sure you were waiting for that to throw it in my face at the right moment ;) It would have been nicer without the allegations, but I didn't expect it otherwise in the heat of this discussion. > > PS You don't need the CFLAGS="-O2" (anymore?), > > It is used deliberately, because more optflags break rpm2html and make it > segfault real badly. It doesn't segfault here on RH80, RH90 and RHFC1. That's why I thought you had it in place for earlier versions. Aparantly not. No harm done. > > the %makeinstall macro works too > > Sure, but DESTDIR= install is the de facto standard and works in this > case, too. But you wouldn't be using the correct macros. On a x86_64 it would get installed in /usr/lib instead of /usr/lib64. (This example doesn't have libraries, but it would have been good practice to do it everywhere if possible). > > and I would %config(noreplace) the config-file. > > I disagree. It is an example only, and rpm2html power-users would run > rpm2html with separate config files and as non-root anyway. YMMV. Ok, then we agree to disagree. Minor issue. -- dag wieers, dag@xxxxxxxxxx, http://dag.wieers.com/ -- [Any errors in spelling, tact or fact are transmission errors]
