Re: [PATCH] Move captive portal to fedora-release-workstation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Sep 30, 2014 at 8:12 PM, Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx> wrote:
> On Tue, Sep 30, 2014 at 1:44 PM, drago01 <drago01@xxxxxxxxx> wrote:
>> On Tue, Sep 30, 2014 at 6:49 PM, Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx> wrote:
>>> Pretty much what we discussed on IRC yesterday.  Anyone have problems
>>> with me committing this today?
>>>
>>> josh
>>>
>>> diff --git a/gnome-shell.spec b/gnome-shell.spec
>>> index a085076..94e284d 100644
>>> --- a/gnome-shell.spec
>>> +++ b/gnome-shell.spec
>>> @@ -102,8 +102,6 @@ Requires:       gdm-libs%{?_isa}
>>>  Requires:       clutter%{?_isa} >= %{clutter_version}
>>>  # needed for settings items in menus
>>>  Requires:        control-center
>>> -# needed for captive portal support
>>> -Requires:       NetworkManager-config-connectivity-fedora
>>>
>>>  %description
>>>  GNOME Shell provides core user interface functions for the GNOME 3 desktop,
>>> diff --git a/fedora-release.spec b/fedora-release.spec
>>> index 333875f..1d7db6b 100644
>>> --- a/fedora-release.spec
>>> +++ b/fedora-release.spec
>>> @@ -72,6 +72,8 @@ Requires:       fedora-release = %{version}-%{release}
>>>  Conflicts:      fedora-release-cloud
>>>  Conflicts:      fedora-release-server
>>>  Conflicts:      fedora-release-standard
>>> +# needed for captive portal support
>>> +Requires:       NetworkManager-config-connectivity-fedora
>>>
>>>  %description workstation
>>>  Provides a base package for Fedora Workstation-specific configuration files to
>>
>> I don't really like that people that do upgrades get a worse
>> experience because of that pointless change but well ...
>
> There's nothing that says a user doing an upgrade wants to upgrade to
> Workstation.  There's also nothing that is going to magically upgrade
> them to Workstation anyway.

Which is an different issue and is not really relevant here. The user
has been using GNOME upgrades
to a new release and should have the experience designed in the new
GNOME release.

>  Also, they don't have this in F20 so  their experience is not worse, it's the same.

It's worse than someone that re installs F21 which is my point (also
the reason why the dep has been added to gnome-shell).
Compare that cost to the gain of the change.  The latter is basically
non existent. I mean if we would solve some big problem by that
that might be an OK trade off .... but we aren't.
-- 
desktop mailing list
desktop@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/desktop





[Index of Archives]     [Fedora Users]     [Fedora KDE]     [Fedora Announce]     [Fedora Docs]     [Fedora Config]     [PAM]     [Red Hat Development]     [Red Hat 9]     [Gimp]     [Yosemite News]

  Powered by Linux