On Mon, 2013-04-29 at 13:48 +0200, Bastien Nocera wrote: > On Mon, 2013-04-29 at 14:36 +0300, Elad Alfassa wrote: > > > > > > > > On Mon, Apr 29, 2013 at 2:34 PM, Bastien Nocera <bnocera@xxxxxxxxxx> > > wrote: > <snip> > > Why does it need samba-client? It's a package containing > > command-line > > utilities none of which seem to be used by > > gnome-control-center. > > I have no idea, all I know is that I got an error trying to add a > > samba printer without this package installed. Same issue happens with > > system-config-printer (just a bit more verbose, saying "CUPS ERROR NOT > > POSSIBLE" or something similar, so it must be some lousy cups > > problem) > > Then it seems to me that cups or system-config-printer are missing the > dep, not control-center. > > $ FILES=`rpm -ql system-config-printer | grep 'py$'` ; for i in `rpm -ql > samba-client | grep /bin/` ; do BASENAME=`basename $i` ; grep -l > $BASENAME $FILES && echo $i ; done > /usr/share/system-config-printer/troubleshoot/CheckPrinterSanity.py > /usr/bin/nmblookup > > Looks like system-config-printer might be responsible for the missing > dep. Would be better if that wasn't needed though. Note that I already addressed this for F19 to some extent: https://git.fedorahosted.org/cgit/spin-kickstarts.git/commit/?id=2c04fe5d624c3b9c1d3658b8fe0c8b4a71c910bb samba-client is in fact in a default install, but we were explicitly dropping it from the live images to "save some space", presumably because we figured it wasn't really needed. Dedoimedo noticed this issue in his review of F18, so I looked into it, and got samba-client taken out of live-minimization.ks , which means it won't be removed from the F19 live images. I don't really mind whether we add a hard dep or not (it might cause some people to complain about bloat and yadda yadda), I just thought it was worth pointing out that this is probably already 'fixed' for most practical cases. -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora http://www.happyassassin.net -- desktop mailing list desktop@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/desktop
