On Tue, 2009-10-27 at 22:42 +0000, Bastien Nocera wrote: > When trying to build the fix into F12, I noticed we have a few of our > own changes. > > Could you please make sure that: > http://koji.fedoraproject.org/koji/buildinfo?buildID=138682 > also looks as expected for you? > It looks crisp, but the fill is one pixel smaller then it should be (see the attachment). Looks like this shouldn't be there: - x1 = round ((width - 1) * percentage); + x1 = round ((width - 2) * percentage); and this: - cairo_rectangle (cr, x0 + 0.5, y0 + 0.5, x1, height - 1); + rounded_rectangle (cr, 1.0, x0 + 0.5, y0 + 0.5, height / 8, x1, height - 2); should look like - cairo_rectangle (cr, x0 + 0.5, y0 + 0.5, x1, height - 1); + rounded_rectangle (cr, 1.0, x0 + 0.5, y0 + 0.5, height / 6 - 0.5, x1, height - 1); in "0003-Improve-the-media-keys-overlay-design.patch". The "height / 6 - 0.5" gives better correlation with the through rectangle's radius than "height / 8" (but isn't a big deal) and the substitutions of 2's instead of 1's with the change from cairo_rectangle to rounded_rectangle and in the x1 setting are obviously incorrect. Martin
Attachment:
volume-fill.png
Description: PNG image
Attachment:
signature.asc
Description: This is a digitally signed message part
-- Fedora-desktop-list mailing list Fedora-desktop-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-desktop-list
