On Fri, 2004-02-20 at 12:52, Shannon --jj Behrens wrote: > Once again, I'm backseat driving, without even knowing exactly what you > guys are doing: I'm guessing if you have a method named "as_string", > you might want to name it __str__ so that str(myInstace) works. :) I mentioned that I don't think it's a good idea to use the as_string as the method name. When we're generating the whole file, some of the upper classes like table and chain will have to generate multiple lines, so I thought to make it uniform we just use generate(). Also I should mention this while I'm here. Rather than returning strings in the lower level classes, I think they should return lists of tokens so that space delimiting and ordering can happen in one place like the Chain class's generate() method when it puts together the finished rule line. This way we don't have to look at the parent and child classes to see where white space is needed for each generate(). As a side note, I've started work on the system.py module with a bunch of functions to query and change things like /proc/sys/net/ipv4/ip_forward, /etc/sysctl.conf, what table modules are installed in the kernel, what net devices there are in the system, etc. Maybe I should name this something other than system.py so there isn't confusion with python's sys module? Any ideas? I didn't make it a class because I thought it would be a bad idea to have multiple objects of this type floating around. I'll post a link to the file once I get it mostly done. If there's any other useful system interaction we need let me know. -Tim -- Timothy A. Chagnon <tchagnon@xxxxxxxxx>