On Jul 13, 2005 00:43 +0200, Adrian Bunk wrote: > On Tue, Jul 12, 2005 at 04:32:44PM -0600, Andreas Dilger wrote: > > I don't mind removing this function, but it shouldn't be put inside #ifdef > > JBD_DEBUG, as that would remove the check from the compiler-parsed code > > and defeat the purpose of the check. > > That's not what my patch is doing. > > journal_init() is not inside an #ifdef JBD_DEBUG. My bad. You didn't generate diff with -p (which I normally do and is incredibly useful when reviewing patches) and I saw "write_jbd_debug()" above and my brain went on autopilot assuming the code had moved into that function. Objection withdrawn. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. _______________________________________________ Ext3-users@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/ext3-users
