On Tue, Jul 12, 2005 at 04:32:44PM -0600, Andreas Dilger wrote:
> On Jul 12, 2005 22:27 +0200, Adrian Bunk wrote:
>...
> > - journal.c: remove the unused global function __journal_internal_check
> > and move the check to journal_init
>
> I don't mind removing this function, but it shouldn't be put inside #ifdef
> JBD_DEBUG, as that would remove the check from the compiler-parsed code
> and defeat the purpose of the check.
???
That's not what my patch is doing.
journal_init() is not inside an #ifdef JBD_DEBUG.
>...
> > - remove the following unneeded EXPORT_SYMBOL's:
> > - journal.c: journal_check_used_features
>
> Should be kept for API completeness.
>...
The function itself isn't removed.
Does it really has to stay exported or isn't it enough to re-export it
when a user appears?
> Cheers, Andreas
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
_______________________________________________
Ext3-users@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/ext3-users
