Hello, I've seen earlier discussions about ecryptfs ablkcipher patch, but I see it was not merged. Are you planning to apply this patch in the future, or did you decide to drop it? I tried to apply the patch locally and saw the following issues: 1. I've encountered a problem with ecryptfs_encrypt_extent_done that is calling functions that can sleep (kmap/kunmap). It fails with ablkcipher crypto drivers that invoke the callback from interrupt handler bh (tasklet). Moving the write part to a work queue (using queue_work) seems to solve it. 2. I saw that ecryptfs was reverted from writeback to writethrough cache mode. This seems to be problematic in regard to performance while using async interfaces. The original change to writepage (that uses ecryptfs_encrypt_page_async) allowed submitting async crypto operations and continuing without waiting for the result. write_end uses ecryptfs_encrypt_page (and needs its return value), so we'll have to wait for encryption (and write) to complete before continuing to the next operation. Are you planning to return ecryptfs cache to writeback mode? Thank you, Zeev. -- To unsubscribe from this list: send the line "unsubscribe ecryptfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
