On Tue, Oct 22, 2024 at 03:17:09PM -0700, Stephen Brennan wrote: > Alan Maguire <alan.maguire@xxxxxxxxxx> writes: > > ...as this means we avoid seeing multiple messages of the form > > PAHOLE: Warning: Found invalid variable name when encoding btf, ignored (sym: '__UNIQUE_ID___addressable__RNvXsa_NtCs2vSfyxKMEZc_4core4charNtB5_11EscapeDebugNtNtNtNtB7_4iter6traits10exact_size17ExactSizeIterator3len57'). > > a beautiful variable name :P A unique one :-) > > Such symbols are filtered anyway due to the __UNIQUE_ID prefix, so > > warning about them is not necessary; simply reordering the checks > > should ensure we will not see these warnings. > > Reported-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > > Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx> > Sorry I'm late to review. This is a good catch and is clearly correct > to me. Thanks, since it hasn't moved to master, I'm adding it. > Reviewed-by: Stephen Brennan <stephen.s.brennan@xxxxxxxxxx> - Arnaldo
