...as this means we avoid seeing multiple messages of the form
PAHOLE: Warning: Found invalid variable name when encoding btf, ignored (sym: '__UNIQUE_ID___addressable__RNvXsa_NtCs2vSfyxKMEZc_4core4charNtB5_11EscapeDebugNtNtNtNtB7_4iter6traits10exact_size17ExactSizeIterator3len57').
Such symbols are filtered anyway due to the __UNIQUE_ID prefix, so
warning about them is not necessary; simply reordering the checks
should ensure we will not see these warnings.
Reported-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx>
---
btf_encoder.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/btf_encoder.c b/btf_encoder.c
index 5954238..e507e60 100644
--- a/btf_encoder.c
+++ b/btf_encoder.c
@@ -2241,6 +2241,9 @@ static int btf_encoder__encode_cu_variables(struct btf_encoder *encoder)
if (!name)
continue;
+ if (filter_variable_name(name))
+ continue;
+
/* Check for invalid BTF names */
if (!btf_name_valid(name)) {
dump_invalid_symbol("Found invalid variable name when encoding btf",
@@ -2251,9 +2254,6 @@ static int btf_encoder__encode_cu_variables(struct btf_encoder *encoder)
return -1;
}
- if (filter_variable_name(name))
- continue;
-
if (var->ip.tag.type == 0) {
fprintf(stderr, "error: found variable '%s' in CU '%s' that has void type\n",
name, cu->name);
--
2.43.5
