On 14 December 2015 at 08:12, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Sat, Dec 12, 2015 at 03:26:09PM +0000, Emil Velikov wrote: >> Hi Thierry, all, >> >> On 9 December 2015 at 17:37, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: >> > From: Thierry Reding <treding@xxxxxxxxxx> >> > >> > Some of the helpers, such as the pattern drawing helpers or the format >> > lookup helpers, have potential to be reused. Move them into a separate >> > library to make it easier to share them. >> > >> > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >> > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> >> > --- >> > CleanSpec.mk | 1 + >> > configure.ac | 1 + >> > tests/Makefile.am | 2 +- >> > tests/modeprint/Makefile.am | 1 + >> > tests/modeprint/modeprint.c | 2 +- >> > tests/modetest/Android.mk | 1 + >> > tests/modetest/Makefile.am | 8 +- >> > tests/modetest/buffers.c | 961 +------------------------------------------- >> > tests/modetest/buffers.h | 12 +- >> > tests/modetest/cursor.c | 4 +- >> > tests/modetest/modetest.c | 25 +- >> > tests/proptest/Makefile.am | 4 +- >> > tests/proptest/proptest.c | 3 +- >> > tests/util/Android.mk | 39 ++ >> > tests/util/Makefile.am | 13 + >> > tests/util/Makefile.sources | 6 + >> > tests/util/common.h | 33 ++ >> > tests/util/format.c | 120 ++++++ >> > tests/util/format.h | 65 +++ >> > tests/util/pattern.c | 870 +++++++++++++++++++++++++++++++++++++++ >> > tests/util/pattern.h | 39 ++ >> > tests/vbltest/Makefile.am | 1 + >> > tests/vbltest/vbltest.c | 2 +- >> > 23 files changed, 1223 insertions(+), 990 deletions(-) >> > create mode 100644 tests/util/Android.mk >> > create mode 100644 tests/util/Makefile.am >> > create mode 100644 tests/util/Makefile.sources >> > create mode 100644 tests/util/common.h >> > create mode 100644 tests/util/format.c >> > create mode 100644 tests/util/format.h >> > create mode 100644 tests/util/pattern.c >> > create mode 100644 tests/util/pattern.h >> > >> As mentioned on IRC, although there might be some minor nitpicks I'd >> rather the series in those in and fix them later. Mostly to avoid the >> long gap until you get the chance to respin things, but also to spare >> Tomi (and others) the need to reinvent them :-) > > I don't mind doing another round if you point out the nitpicks. I'm > hopeful that I'll get around to respinning sooner this time. =) > The only thing that I've noticed was a lack of teardown in most/all error paths. Which is ... both very low priority and almost impossible to get right/test. If you want to sort those, but all means please do. Alternatively we'll get them some day ;-) Thanks Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
