Re: [PATCH libdrm 01/10] tests: Split helpers into library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Thierry, all,

On 9 December 2015 at 17:37, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> Some of the helpers, such as the pattern drawing helpers or the format
> lookup helpers, have potential to be reused. Move them into a separate
> library to make it easier to share them.
>
> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
>  CleanSpec.mk                |   1 +
>  configure.ac                |   1 +
>  tests/Makefile.am           |   2 +-
>  tests/modeprint/Makefile.am |   1 +
>  tests/modeprint/modeprint.c |   2 +-
>  tests/modetest/Android.mk   |   1 +
>  tests/modetest/Makefile.am  |   8 +-
>  tests/modetest/buffers.c    | 961 +-------------------------------------------
>  tests/modetest/buffers.h    |  12 +-
>  tests/modetest/cursor.c     |   4 +-
>  tests/modetest/modetest.c   |  25 +-
>  tests/proptest/Makefile.am  |   4 +-
>  tests/proptest/proptest.c   |   3 +-
>  tests/util/Android.mk       |  39 ++
>  tests/util/Makefile.am      |  13 +
>  tests/util/Makefile.sources |   6 +
>  tests/util/common.h         |  33 ++
>  tests/util/format.c         | 120 ++++++
>  tests/util/format.h         |  65 +++
>  tests/util/pattern.c        | 870 +++++++++++++++++++++++++++++++++++++++
>  tests/util/pattern.h        |  39 ++
>  tests/vbltest/Makefile.am   |   1 +
>  tests/vbltest/vbltest.c     |   2 +-
>  23 files changed, 1223 insertions(+), 990 deletions(-)
>  create mode 100644 tests/util/Android.mk
>  create mode 100644 tests/util/Makefile.am
>  create mode 100644 tests/util/Makefile.sources
>  create mode 100644 tests/util/common.h
>  create mode 100644 tests/util/format.c
>  create mode 100644 tests/util/format.h
>  create mode 100644 tests/util/pattern.c
>  create mode 100644 tests/util/pattern.h
>
As mentioned on IRC, although there might be some minor nitpicks I'd
rather the series in those in and fix them later. Mostly to avoid the
long gap until you get the chance to respin things, but also to spare
Tomi (and others) the need to reinvent them :-)

So barring any serious objections, I'd vote for getting these soonish.
Perhaps mid next week ?

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux