On Wed, Aug 12, 2015 at 11:32 AM, Daniel Vetter <daniel@xxxxxxxx> wrote: > On Wed, Aug 12, 2015 at 05:00:31PM +0200, Thierry Reding wrote: >> From: Thierry Reding <treding@xxxxxxxxxx> >> >> Name all references to the pipe number (CRTC index) consistently to make >> it easier to distinguish which is a pipe number and which is a pointer >> to struct drm_crtc. >> >> While at it also make all references to the pipe number unsigned because >> there is no longer any reason why it should ever be negative. >> >> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > > There's 2 "int crtc" and one "int pipe" (without the unsigned) left after > this patch. Can you please do a follow-up? Applied this meanwhile. 4.3 is about to get released, and the regression for nouveau that this change introduces (https://bugzilla.kernel.org/show_bug.cgi?id=106431) is still not fixed. Can you remove the warn for now or explicitly allow ~0U? Don't want to start spewing warns for everyone with a pre-tesla nvidia gpu... Thanks, -ilia _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
