Regards
Shashank
On 10/13/2015 6:53 PM, Emil Velikov wrote:
On 10 October 2015 at 06:21, Sharma, Shashank <shashank.sharma@xxxxxxxxx> wrote:
On 10/10/2015 5:09 AM, Emil Velikov wrote:
Hi Shashank,
On 9 October 2015 at 20:29, Shashank Sharma <shashank.sharma@xxxxxxxxx>
[snip]
+ switch (num_samples) {
+ case GAMMA_DISABLE_VALS:
+
+ /* Disable Gamma functionality on Pipe */
Drop the extra newline between the case and the comment ? Here and below.
I was trying to make it look good :(
Beauty is in the eye of the beholder. The most important part here is
consistency.
Afaict there isn't (m)any i915 code the uses this approach, is there ?
Some of your other patches use this approach while others don't.
I prefer to leave one extra line when I have a comment, so that comment
is more visible, instead of being sandwiched between lines of C code.
May be I missed some places, so I can make it consistent.
Regards,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
