Re: [PATCH 19/22] drm/i915: BDW: Pipe level Gamma correction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10 October 2015 at 06:21, Sharma, Shashank <shashank.sharma@xxxxxxxxx> wrote:
> On 10/10/2015 5:09 AM, Emil Velikov wrote:
>>
>> Hi Shashank,
>>
>> On 9 October 2015 at 20:29, Shashank Sharma <shashank.sharma@xxxxxxxxx>
[snip]
>>> +       switch (num_samples) {
>>> +       case GAMMA_DISABLE_VALS:
>>> +
>>> +               /* Disable Gamma functionality on Pipe */
>>
>> Drop the extra newline between the case and the comment ? Here and below.
>>
> I was trying to make it look good :(
Beauty is in the eye of the beholder. The most important part here is
consistency.
Afaict there isn't (m)any i915 code the uses this approach, is there ?
Some of your other patches use this approach while others don't.

Regards,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux