On 29 May 2015 at 07:34, Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> wrote:
> On 05/28/2015 10:02 PM, Emil Velikov wrote:
>> On 28 May 2015 at 00:56, Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> wrote:
>>> The build error is introduced by commit fde496917682 ("Add device
>>> enumeration interface (v4)") if don't enable udev. Can solve as check
>>> UDEV dependency.
>>>
>>> CC libdrm_la-xf86drm.lo
>>> xf86drm.c:66:21: fatal error: libudev.h: No such file or directory
>>> #include "libudev.h"
>>> ^
>>> compilation terminated.
>>> make[2]: *** [libdrm_la-xf86drm.lo] Error 1
>>>
>>> Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
>>> ---
>>> xf86drm.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/xf86drm.c b/xf86drm.c
>>> index b5a174b..4a31019 100644
>>> --- a/xf86drm.c
>>> +++ b/xf86drm.c
>>> @@ -63,7 +63,9 @@
>>>
>>> #include "xf86drm.h"
>>> #include "libdrm_macros.h"
>>> +#if defined(UDEV)
>> The macro you're looking for (here and below) is #if HAVE_LIBUDEV.
>>
>
> I'm not sure it's right using HAVE_LIBUDEV instead of UDEV because
> currently UDEV is used from .c file but HAVE_LIBUDEV is not.
>
I'm afraid that I giggled a bit while I read this. Surely you know the
difference between udev and libudev, and after a brief inspection of
the code, original and newly added, you can see that it differs
significantly. Additionally the newly added LIBUDEV_{CFLAGS,LIBS}
should be a nice give-away :-)
That aside, I'll send a revert in a second as mentioned previously.
Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
