From: Christian König <christian.koenig@xxxxxxx> Date: Thu, 19 Mar 2015 09:50:58 +0100 > In general I would say yes, but for this particular hardware it's a > bit questionable to do so. > > For radeon hardware to work correctly the CPU access to the PCIE BARs > should work even without using the specialized IO macros/functions, > otherwise mapping VRAM CPU accessible isn't really possible. > > What's the background of the change? Some problems on a certain CPU > platform? or just general cleanups? It's an _iomem_ pointer, it's not a virtual address. Therefore it is illegal to dereference the pointer. The value is opaque and has values that only make sense when used with the readb() et al. interfaces. This code is relying upon the fact that on x86 it happens to be a virtual address, but this won't work on many other architectures. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
