Is there any gating item to prevent these patches (5+2) from being merged? 2015-03-19 10:56 GMT+08:00 Chih-Wei Huang <cwhuang@xxxxxxxxxxxxxxx>: > 2015-03-19 10:06 GMT+08:00 Emil Velikov <emil.l.velikov@xxxxxxxxx>: >> On 18/03/15 16:38, Chih-Wei Huang wrote: >>> 2015-03-18 9:37 GMT+08:00 Emil Velikov <emil.l.velikov@xxxxxxxxx>: >>>> > On 18 March 2015 at 01:19, Chih-Wei Huang <cwhuang@xxxxxxxxxxxxxxx> wrote: >>>>> >> >>>>> >> I would suggest to remove all the use of LIBDRM_TOP. >>>>> >> Do you want me to submit a patch? >>>> > Hmm I'm not sure that things will work correctly if we directly >>>> > substitute LIBDRM_TOP with LOCAL_PATH within the following. >>>> > >>>> > mkfiles := $(patsubst %,$(LIBDRM_TOP)/%/Android.mk,$(SUBDIRS)) >>> Sure. It works. >>> But I prefer to simplify it by android build system >>> built-in functions. See the attached 0001-* patch. >>> >>> 0002-* removes LIBDRM_TOP entirely. >>> >> I realise that most people aren't too exited about Android, but for the >> future please try to use git send-email when sending patches to >> dri-devel or mesa-dev. I've included them below for posterity. >> >> Patches look good imho. Just one question - when was the >> all-makefiles-under macro introduced ? I haven't seen it used too often. > > It's introduced since very early day of android. > (git blame shows it's in commit 88b60799) > > Personally I use it often. -- Chih-Wei Android-x86 project http://www.android-x86.org _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
