On Tue, 2015-02-10 at 00:27 +0000, Emil Velikov wrote: > On 10 February 2015 at 00:02, Jan Vesely <jan.vesely@xxxxxxxxxxx> wrote: > > On Mon, 2015-02-09 at 23:32 +0000, Emil Velikov wrote: > >> On 9 February 2015 at 21:39, Jan Vesely <jan.vesely@xxxxxxxxxxx> wrote: > >> > Signed-off-by: Jan Vesely <jan.vesely@xxxxxxxxxxx> > >> Nice one Jan. I've sent similar fixes for drmOpenDevice and > >> drmGetStats a few days ago. > >> > >> Considering you drop the last hunk that Ian spotted both patches are > >> Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx> > > > > Thanks, I sent v2 of that patch few minutes ago. > > > > I think your 4/6 and 5/6 overlap with this one. Should I go ahead or do > > you plan to push yours? > > > I would go with your series - it handles more cases, plus already has > move reviews :-P > If you feel like looking through some of my series that would be appreciated. I wasn't subscribed to the list so I can't reply to those emails (don't know the message-ids). I looked at the series from Jan 29th [0]. 1/6[1], there is no tests/util directory, I guess it depends on Thierry's series? since it hasn't landed yet does it make sense to squash it there (like your 04.1/11 SQUASH: tests: misc cleanups) ? 2/6[2], also does not apply cleanly (needs Thierry's 5/11), if you want to push a version rebased on master you can add Reviewed-by: Jan Vesely <jan.vesely@xxxxxxxxxxx> to that one 4/6 and 5/6 were superseded, and I don't know enough about android to look at the other two, but 6/6 looks trivial enough Acked-by: Jan Vesely <jan.vesely@xxxxxxxxxxx> with a small nit: Why keep two assignments to LOCAL_SHARED_LIBRARIES in intel/Android.mk ? regards, jan [0]http://lists.freedesktop.org/archives/dri-devel/2015-January/076456.html [1]http://lists.freedesktop.org/archives/dri-devel/2015-January/076457.html [2]http://lists.freedesktop.org/archives/dri-devel/2015-January/076458.html > > >> > >> The strange part is that the normal Linux build does not show even a > >> single warning, despite the -Wextra and -Wsign-compare flags from > >> configure.ac. Perhaps my gcc does not like libdrm for some reason :P > > > > I think I just used CFLAGS= during configure, and it worked > > jan > > > Yes the issue was that we're not using WARN_CFLAGS in every Makefile in libdrm. > Namely the top one and most of the tests. > > -Emil -- Jan Vesely <jan.vesely@xxxxxxxxxxx>
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
