Re: [libdrm][PATCH 2/2] Fix gcc -Wextra warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2015-02-09 at 23:32 +0000, Emil Velikov wrote:
> On 9 February 2015 at 21:39, Jan Vesely <jan.vesely@xxxxxxxxxxx> wrote:
> > Signed-off-by: Jan Vesely <jan.vesely@xxxxxxxxxxx>
> Nice one Jan. I've sent similar fixes for drmOpenDevice and
> drmGetStats a few days ago.
> 
> Considering you drop the last hunk that Ian spotted both patches are
> Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx>

Thanks, I sent v2 of that patch few minutes ago.

I think your 4/6 and 5/6 overlap with this one. Should I go ahead or do
you plan to push yours?

> 
> The strange part is that the normal Linux build does not show even a
> single warning, despite the -Wextra and -Wsign-compare flags from
> configure.ac. Perhaps my gcc does not like libdrm for some reason :P

I think I just used CFLAGS= during configure, and it worked
jan

> 
> -Emil

-- 
Jan Vesely <jan.vesely@xxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux