On Thu, Nov 13, 2014 at 06:47:34PM +0100, Borislav Petkov wrote: > On Thu, Nov 13, 2014 at 07:33:54PM +0200, Ville Syrjälä wrote: > > We use it both ways in i915. So please don't break it. > > Haha, we started from Intel with Ross' patch and made a full circle > back. Maybe you guys should talk about it. > > LOL. :-) Indeed. The problem I see with these patches is that they don't actually tell what the new instruction does, so a casual glance doesn't really raise any red flags. Another excuse I can use is that I just got used to the fact that the x86 hasn't historically bothered separating invalidate and writeback and just does both. In my previous life on the dark^Warm side I did actually know the difference :) But there's plenty of blame to go around to the other side of the fence too. We should have documented what we expect from these functions. Currently you just have to know/guess, and that's just not good enough. -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
