On Mon, Sep 22, 2014 at 4:39 PM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > On Tue, Sep 02, 2014 at 10:56:46AM +0800, Daniel Kurtz wrote: > > There are several different models of N116BGE. According to the commit > > that added innolux_n116bge_mode [0], this N116BGE is for the eDP variety. > > > > [0] commit 0a2288c06aab73c966e82045c8f20b0e713baf2a > > Author: Thierry Reding <treding@xxxxxxxxxx> > > Date: Thu Jul 3 14:02:59 2014 +0200 > > > > drm/panel: simple: Add Innolux N116BGE panel support > > > > The clock and htotal values from add by that patch are out of spec according to > > the datasheets I have seen for the eDP N116BGE (-EA2 and -EB2). > > Does out of spec imply that these timings aren't working for you? No, I didn't even try with your values, actually. Out of spec just means that the numbers do not fall between Min and Max on the datasheet: 72.6 <= DCLK <= 80.24 vs. 71 1506 <= htotal <= 1716 vs. 1500 > > This patch changes the values to the "Typ" values on the datasheet. > > The original patch was based on -E42 of the datasheet. But I can run > some tests to see if the timings in this patch work on the panel that I > have. If so I guess the easiest would be to apply this. Thanks! > > It shouldn't matter all that much since the panel has EDID if I remember > correctly. The modes parsed from EDID should take precedence over the > fixed mode. If they don't then that's a bug. The driver I am testing this with does not yet support reading the EDID over eDP, so I am using the fixed values for now. > Thierry > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
