On Tue, Sep 02, 2014 at 10:56:46AM +0800, Daniel Kurtz wrote:
> There are several different models of N116BGE. According to the commit
> that added innolux_n116bge_mode [0], this N116BGE is for the eDP variety.
>
> [0] commit 0a2288c06aab73c966e82045c8f20b0e713baf2a
> Author: Thierry Reding <treding@xxxxxxxxxx>
> Date: Thu Jul 3 14:02:59 2014 +0200
>
> drm/panel: simple: Add Innolux N116BGE panel support
>
> The clock and htotal values from add by that patch are out of spec according to
> the datasheets I have seen for the eDP N116BGE (-EA2 and -EB2).
Does out of spec imply that these timings aren't working for you?
> This patch changes the values to the "Typ" values on the datasheet.
The original patch was based on -E42 of the datasheet. But I can run
some tests to see if the timings in this patch work on the panel that I
have. If so I guess the easiest would be to apply this.
It shouldn't matter all that much since the panel has EDID if I remember
correctly. The modes parsed from EDID should take precedence over the
fixed mode. If they don't then that's a bug.
Thierry
>
> Signed-off-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>
> ---
>
> Thierry,
>
> It is possible that your timings were correct for the panel you are using on
> the norrin reference board. In that case I'm happy to upload a new patch
> that creates a new panel entry. However, I'm pretty sure we are using the
> same N116BGE.
>
> drivers/gpu/drm/panel/panel-simple.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 4ce1db0..776764a 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -519,15 +519,15 @@ static const struct panel_desc foxlink_fl500wvr00_a0t = {
> };
>
> static const struct drm_display_mode innolux_n116bge_mode = {
> - .clock = 71000,
> + .clock = 76420,
> .hdisplay = 1366,
> - .hsync_start = 1366 + 64,
> - .hsync_end = 1366 + 64 + 6,
> - .htotal = 1366 + 64 + 6 + 64,
> + .hsync_start = 1366 + 136,
> + .hsync_end = 1366 + 136 + 30,
> + .htotal = 1366 + 136 + 30 + 60,
> .vdisplay = 768,
> .vsync_start = 768 + 8,
> - .vsync_end = 768 + 8 + 4,
> - .vtotal = 768 + 8 + 4 + 8,
> + .vsync_end = 768 + 8 + 12,
> + .vtotal = 768 + 8 + 12 + 12,
> .vrefresh = 60,
> .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> };
> --
> 2.1.0.rc2.206.gedb03e5
>
Attachment:
pgppLCO8dre8G.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
