On Mon, Sep 8, 2014 at 8:01 AM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: > Hi Josh > > On 05/09/14 18:19, Josh Boyer wrote: >> The userspace drm.h include doesn't prefix the drm directory. This can lead >> to compile failures as /usr/include/drm/ isn't in the standard gcc include >> paths. Fix it to be <drm/drm.h>, which matches the rest of the driver drm >> header files that get installed into /usr/include/drm. >> > Is this an actual issue or a hypothetical one ? Afaict no-one is using the > kernel drm headers, but instead the ones from libdrm are in place. > linux-headers does not even ship /usr/include/drm on my Archlinux box. It's shipped in kernel-headers in Fedora and I'm guessing someone hit it at one point, but I don't know what the actual initial problem was. > Additionally most (all?) vmwgfx components (mesa, ddx) use a local version of > the header, which albeit not ideal should not cause issues. > > Or perhaps I'm missing something ? > > > To the VMware guys, > > Any objections if we update the libdrm header and drop the mesa/ddx copies ? > > Cheers, > Emil > > P.S. I'm against the patch in any way :) Was that meant to say "I'm not against the patch in any way" ? josh _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
