On Thu, Jul 03, 2014 at 10:52:00PM +0100, Russell King - ARM Linux wrote: > On Thu, Jul 03, 2014 at 05:31:21PM -0400, Rob Clark wrote: > > >From a brief look, it looks like my comments have been addressed, so I > > think this is starting to shape up.. > > > > Laurent/Thierry/Russell, I don't suppose any of you are likely to have > > time before 3.17 merge window to give sti one last once-over to see > > what I missed ;-) > > As this appears to be using the component helpers, it would be good for > the author to be pre-warned about the change to the API. I'm going to > be doing this as a two step thing. More on this... just found it in the series. It looks fine, and I expect that the update would be trivial: - the body of sti_drm_add_components() moves into sti_drm_master_probe() and sti_drm_add_components() is removed. - component_master_add_child() is updated to call component_match_add() - component_master_add() is updated to call component_master_add_with_match() instead. So I don't think there's any problem here. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
