On Thu, Jul 03, 2014 at 05:31:21PM -0400, Rob Clark wrote: > >From a brief look, it looks like my comments have been addressed, so I > think this is starting to shape up.. > > Laurent/Thierry/Russell, I don't suppose any of you are likely to have > time before 3.17 merge window to give sti one last once-over to see > what I missed ;-) As this appears to be using the component helpers, it would be good for the author to be pre-warned about the change to the API. I'm going to be doing this as a two step thing. The first stage of it has just been taken by Greg this evening. This retires old behaviour that was needed for the initial versions of imx-drm, and fixes a bug. More importantly, it introduces a new interface where you build the list of expected components before calling component_master_add(), passing it into that function. It is slightly less flexible from the driver writer's view point, but allows us to do more in the component helper, and support some features that others would like to see (such as being able to add additional optional components after the initial bind (that's not much interest to DRM though.) This should make the v3.17 merge window. I'm hoping that by forewarning about the change, that people can be aware of it and have patches prepared for v3.18 (or maybe even v3.17) to convert over to it, so we can get rid of the older interface before we get too many users of it. I've just peeked at the binding document in the first patch. I notice that it isn't making use of the of_graph stuff, which is a bit of a shame because I've sent a RFC patch adding drivers/gpu/drm/drm_of.c to provide a helper which encoders can use to get the CRTC mask from an of_graph representation. I'm using this not only for imx-drm, but also for tda998x - and that's where the problems are likely to start if we end up with different DRM implementations doing different solutions to the connectivity problem. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
