On Thu, 3 Jul 2014 16:43:25 +0100 Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > What you're doing in kirkwood-i2s is providing two plain DAI links, > and then insisting that only one can be active any any one time. > > A DPCM solution provides at least one frontend DAI link and at least > one backend DAI link. Your code does not do this. You know why I did not insert the DPCM code in the kirkwood driver: it does not work. But, as I tested it end 2013, I still have the code. Do you want I propose a patch? > Which bit of "we need to support both I2S and SPDIF" in my previous > emails was not clear. Which bit of "We should only support SPDIF > on the Cubox" was not clear? > > I *fully* acknowledge that we need to support both, but I'm putting > a _strong_ recommendation to you _with_ technical reasons why we > should _only_ support SPDIF on the Cubox. Sorry, I still don't see why only S/PDIF should be supported on the Cubox. I have both, and both are working on HDMI. I hope someone will tell me it also works on S/PDIF: there is no reason it could not. I don't see your technical reasons: you know the constraints of each protocol I2S and S/PDIF. If you don't want I2S, just don't declare it in the DT (see my previous mail). You may also note that I did not put any change relative to the Cubox DT in my patch. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel