On Mon, Jun 23, 2014 at 4:26 PM, Greg KH <greg@xxxxxxxxx> wrote: > On Mon, Jun 23, 2014 at 04:18:39PM -0400, Ilia Mirkin wrote: >> On Mon, Jun 23, 2014 at 4:15 PM, Pavel Machek <pavel@xxxxxx> wrote: >> > Hi! >> > >> >> >> >> > I guess better interface would be something like >> >> >> >> > >> >> >> >> > pstate/07/core_clock_min >> >> >> >> > core_clock_max >> >> >> >> > memory_clock_min >> >> >> >> > memory_clock_max >> >> >> >> > >> >> >> >> > and then pstate/active containing just the number of active state? >> >> > >> >> >> Could we just say that the format of this file is one-per-line of >> >> >> >> >> >> level: information-for-the-user >> >> > >> >> > But it is not. >> >> >> >> But it is... >> >> >> >> > Management tools will want to parse it, sooner or >> >> > later. What is wrong with solution described above? >> >> >> >> It is complex and annoying to the people that will actually use it. >> > >> > grep -r . pstate/ is actually not that bad... >> >> While that's a clever trick that anyone who's done a bunch of stuff >> with sysfs knows, I doubt the average linux user could come up with >> that on their own. I know I didn't. > > That's fine, why would an "average" Linux user ever need to poke around > in sysfs? Again, please describe what you are wanting to have exported > to userspace, and what userspace is supposed to do with that > information, before worrying about the actual sysfs file layout. It would be nice to allow the end-user to switch between performance levels on the card. A particular card exposes some number of levels (well, a particular card's VBIOS), identified by a value between 0-254 (usually identified as a 2-char hex string). Each level has various information associated with it, like timing parameters for various bits of the card, as well as some more user-friendly concepts like "memory clock speed" etc. The card's current state may or may not correspond to one of the predefined levels; often-times the VBIOS initializes the card into some non-level state. This state may also be of some interest to the user. We can't switch to arbitrary speeds, only the defined ones (because of the various other timing parameters). The level ids don't carry too much semantic value (higher usually means faster though), so it would additionally be nice to tell the user some of the more user-friendly information about each level. Different hardware versions will be able to expose different types of information (but always in <name> <clock speed/range> pairs). -ilia _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
