Hi CC: Dave & Daniel On Wed, May 14, 2014 at 3:58 PM, Jani Nikula <jani.nikula@xxxxxxxxx> wrote: > Hi all - > > This series stores connector/encoder names in the relevant structs to > make the name getters thread safe. > > What say you, is the wasted memory too high a price to pay for the > thread safety and implementation simplicity of this approach? I think > making drm_get_connector_name and drm_get_encoder_name return allocated > buffers makes a lot of code really ugly and error prone. > > I am assuming connector_type, connector_type_id, encoder_type, and > encoder.base.id remain unchanged for the lifetime of the > connector/encoder - is that a correct assumption? I like the approach. Using dev-name does not work for encoders, so I'd keep them separate. I mean, we're talking about ~32 bytes per connector here.. Acked-by: David Herrmann <dh.herrmann@xxxxxxxxx> Thanks David _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
