On 12 May 2014 17:57, Alex Deucher <alexdeucher@xxxxxxxxx> wrote: > On Mon, May 12, 2014 at 9:54 AM, Rafał Miłecki <zajec5@xxxxxxxxx> wrote: >> DCE 3.1 and 3.2 have different HDMI registers and should be programmed >> in a slightly different way. Moving support to separated file will >> allow use to use rv770d.h header in the future and adjust code as well. > > Any reason not to split it at DCE3.2 rather than 3.1? It seems like > most (all?) of the changes are DCE3.2 specific rather than DCE3.1. > Otherwise, seems fine to me. I believe DCE 3.1 has HDMI much more like DCE 3.2 and it's programmed in a very similar way. Also it has 3.2 regs like DESCRIPTORs. The biggest difference is that DCE 3.1 doesn't seem to have AFMT_AUDIO_PACKET_CONTROL and AFMT_INFOFRAME_CONTROL0. Take a look at defines for DCE 3.2. Even they are placed in rv770d.h, which is the DCE 3.1 chipset. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
