On Thu, Mar 20, 2025 at 07:18:13PM +0100, Danilo Krummrich wrote: > Hi Mel, > > On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > > +int > > +nouveau_abi16_ioctl_get_zcull_info(ABI16_IOCTL_ARGS) > > +{ > > + struct nouveau_drm *drm = nouveau_drm(dev); > > + struct nvkm_device *device = drm->nvkm; > > + struct drm_nouveau_get_zcull_info *out = data; > > + > > + if (device->has_zcull_info) { > > + *out = device->zcull_info; > > This needs copy_to_user(). Sorry, had the wrong context, drm_ioctl() should already take care of that.