On Wed, Mar 19, 2025 at 11:24:26AM +0800, Yongbang Shi wrote: > From: Baihan Li <libaihan@xxxxxxxxxx> > > To support DP HPD, edid printing, and colorbar display features based on > the Hisislcon DP devices. > --- > ChangeLog: > v6 -> v7: > - add if statement about drm aux in hibmc_dp_connector_get_modes(), suggested by Jani Nikula Where was that suggestion? Also, would you please implement his feedback regarding drm_edid_read()? > v6: https://lore.kernel.org/all/20250310040138.2025715-1-shiyongbang@xxxxxxxxxx/ > v5 -> v6: > - fix the DP_SERDES_VOL2_PRE0 value after electrical test. > - move the detect_ctx() to the patch 7/9. > - add detect_ctx with 200ms delay, suggested by Dmitry Baryshkov. > v5: https://lore.kernel.org/all/20250307101640.4003229-1-shiyongbang@xxxxxxxxxx/ > v4 -> v5: > - add commit log about hibmc_kms_init(), suggested by Dmitry Baryshkov. > - fix the format of block comments, suggested by Dmitry Baryshkov. > - add hibmc_dp_get_serdes_rate_cfg() to correct transferring serdes cfg. > - separate the vga part commit, suggested by Dmitry Baryshkov. > - remove pci_disable_msi() in hibmc_unload() > v4: https://lore.kernel.org/all/20250305112647.2344438-1-shiyongbang@xxxxxxxxxx/ > v3 -> v4: > - fix the serdes cfg in hibmc_dp_serdes_set_tx_cfg(), suggested by Dmitry Baryshkov. > - move the dp serdes registers to dp_reg.h, suggested by Dmitry Baryshkov. > - add comments for if-statement of dp_init(), suggested by Dmitry Baryshkov. > - fix the comment log to imperative sentence, suggested by Dmitry Baryshkov. > - add comments in hibmc_control_write(), suggested by Dmitry Baryshkov. > - add link reset of rates and lanes in pre link training process, suggested by Dmitry Baryshkov. > - add vdac detect and connected/disconnected status to enable HPD process, suggested by Dmitry Baryshkov. > - remove a drm_client, suggested by Dmitry Baryshkov. > - fix build errors reported by kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202502231304.BCzV4Y8D-lkp@xxxxxxxxx/ > v3: https://lore.kernel.org/all/20250222025102.1519798-1-shiyongbang@xxxxxxxxxx/ > v2 -> v3: > - restructuring the header p_reg.h, suggested by Dmitry Baryshkov. > - add commit log about dp serdes, suggested by Dmitry Baryshkov. > - return value in hibmc_dp_serdes_init(), suggested by Dmitry Baryshkov. > - add static const in the array of serdes_tx_cfg[], suggested by Dmitry Baryshkov. > - change drm_warn to drm_dbg_dp, suggested by Dmitry Baryshkov. > - add explanations about dp serdes macros, suggested by Dmitry Baryshkov. > - change commit to an imperative sentence, suggested by Dmitry Baryshkov. > - put HIBMC_DP_HOST_SERDES_CTRL in dp_serdes.h, suggested by Dmitry Baryshkov. > - split the patch into two parts, suggested by Dmitry Baryshkov. > - Capitalized EDID and AUX, suggested by Dmitry Baryshkov. > - rewrite the commit log, suggested by Dmitry Baryshkov. > - move colorbar debugfs entry to this patch, suggested by Dmitry Baryshkov. > - change binary format to integer format, suggested by Dmitry Baryshkov. > - remove mdelay(100) hpd function in ISR, suggested by Dmitry Baryshkov. > - remove enble_display in ISR, suggested by Dmitry Baryshkov. > - change drm_kms_helper_connector_hotplug_event() to > drm_connector_helper_hpd_irq_event(), suggested by Dmitry Baryshkov. > - move macros to dp_reg.h, suggested by Dmitry Baryshkov. > - remove struct irqs, suggested by Dmitry Baryshkov. > - split this patch into two parts, suggested by Dmitry Baryshkov. > v2: https://lore.kernel.org/all/20250210144959.100551-1-shiyongbang@xxxxxxxxxx/ > v1 -> v2: > - splittting the patch and add more detailed the changes in the commit message, suggested by Dmitry Baryshkov. > - changing all names of dp phy to dp serdes. > - deleting type conversion, suggested by Dmitry Baryshkov. > - deleting hibmc_dp_connector_get_modes() and using drm_connector_helper_get_modes(), suggested by Dmitry Baryshkov. > - add colorbar introduction in commit, suggested by Dmitry Baryshkov. > - deleting edid decoder and its debugfs, suggested by Dmitry Baryshkov. > - using debugfs_init() callback, suggested by Dmitry Baryshkov. > - splittting colorbar and debugfs in different patches, suggested by Dmitry Baryshkov. > - optimizing the description in commit message, suggested by Dmitry Baryshkov. > - add mdelay(100) comments, suggested by Dmitry Baryshkov. > - deleting display enable in hpd event, suggested by Dmitry Baryshkov. > v1: https://lore.kernel.org/all/20250127032024.1542219-1-shiyongbang@xxxxxxxxxx/ > --- > > Baihan Li (9): > drm/hisilicon/hibmc: Restructuring the header dp_reg.h > drm/hisilicon/hibmc: Add dp serdes cfg to adjust serdes rate, voltage > and pre-emphasis > drm/hisilicon/hibmc: Add dp serdes cfg in dp process > drm/hisilicon/hibmc: Refactor the member of drm_aux in struct hibmc_dp > drm/hisilicon/hibmc: Getting connector info and EDID by using AUX > channel > drm/hisilicon/hibmc: Add colorbar-cfg feature and its debugfs file > drm/hisilicon/hibmc: Enable this hot plug detect of irq feature > drm/hisilicon/hibmc: Add MSI irq getting and requesting for HPD > drm/hisilicon/hibmc: Add vga connector detect functions > > drivers/gpu/drm/hisilicon/hibmc/Makefile | 3 +- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_aux.c | 16 ++- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h | 10 +- > .../gpu/drm/hisilicon/hibmc/dp/dp_config.h | 2 + > drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 91 +++++++++++- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h | 36 +++++ > drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c | 97 +++++++++---- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h | 130 +++++++++++++----- > .../gpu/drm/hisilicon/hibmc/dp/dp_serdes.c | 71 ++++++++++ > .../drm/hisilicon/hibmc/hibmc_drm_debugfs.c | 104 ++++++++++++++ > .../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 78 ++++++++++- > .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 87 +++++++++--- > .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 12 ++ > .../gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 3 + > 14 files changed, 638 insertions(+), 102 deletions(-) > create mode 100644 drivers/gpu/drm/hisilicon/hibmc/dp/dp_serdes.c > create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_debugfs.c > > -- > 2.33.0 > -- With best wishes Dmitry
