On Mon, Mar 17, 2025 at 6:12 AM Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
On 13/03/2025 01:54, Anusha Srivatsa wrote:
> Start using the new helper that does the refcounted
> allocations.
>
> Signed-off-by: Anusha Srivatsa <asrivats@xxxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 232b03c1a259eb15e423b9d452d28e2ff95c70f8..d7530c3533af34f83ce8c6d6067e7f293f2d4bf1 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -579,7 +579,7 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
> u32 bus_flags;
> int err;
>
> - panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL);
> + panel = devm_drm_panel_alloc(dev, struct panel_simple, base, &panel_simple_funcs);
> if (!panel)
> return -ENOMEM;
>
> @@ -694,8 +694,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
> pm_runtime_set_autosuspend_delay(dev, 1000);
> pm_runtime_use_autosuspend(dev);
>
> - drm_panel_init(&panel->base, dev, &panel_simple_funcs, connector_type);
As pointed by the helpers review, you're loosing the connector_type info here.
Yes Niels, Looking into this. The conector type has to be passed from here to the API...
Anusha
> -
> err = drm_panel_of_backlight(&panel->base);
> if (err) {
> dev_err_probe(dev, err, "Could not find backlight\n");
>
Thanks !
Neil
