Re: [PATCH RFT v2] drm/bridge: ite-it6505: make use of debugfs_init callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +	struct dentry *debugfs = debugfs_create_dir(dev_name(it6505->dev), root);

I will switch away from dev_name() here, too, of course.

> >  	int i = 0;
> >  
> >  	while (debugfs_entry[i].name && debugfs_entry[i].fops) {
> >  		debugfs_create_file(debugfs_entry[i].name, 0644,
> > -				    it6505->debugfs, it6505,
> > -				    debugfs_entry[i].fops);
> > +				    debugfs, it6505, debugfs_entry[i].fops);
> >  		i++;
> >  	}
> >  }
> 
> Ni: I'd say, it's better to move this function rather than moving
> it6505_bridge_funcs. LGTM otherwise.

I started like this but it meant to move all the sysfs file ops code as
well. That was quite a chunk. You still prefer to do it?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux