On Fri, 14 Mar, 2025 15:41:02 +0100 "Miguel Ojeda" <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > On Thu, Mar 13, 2025 at 5:58 PM Benjamin Tissoires <bentiss@xxxxxxxxxx> wrote: >> >> skeletons are good for documentation, but not really for code review as >> they can not compile. >> >> You should make this patch part of a documentation in >> Documentation/hid/, and squash it with the next one (having a minimal >> full driver instead of skeleton+fill in the voids). > > It could be part of the documentation of the `module_hid_driver!` for > instance, like we have done for other of those macros. > > (In general, we try to use `Documentation/` for things that do not fit > as documentation for any of the code "items".) > > Cheers, > Miguel In general, I will add a lot more documentation in my next revision. For example, I have a bunch of unsafe usage right now without any SAFETY comments. Thanks for the review, Rahul Rameshbabu
