Angelo,
On 3/11/25 6:09 AM, AngeloGioacchino Del Regno wrote:
Il 10/03/25 20:59, Ariel D'Alessandro ha scritto:
Now that Panfrost supports AARCH64_4K page table format, let's enable it
on Mediatek MT8188.
Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@xxxxxxxxxxxxx>
---
drivers/gpu/drm/panfrost/panfrost_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/
drm/panfrost/panfrost_drv.c
index 0f3935556ac76..d7b8bded6d784 100644
--- a/drivers/gpu/drm/panfrost/panfrost_drv.c
+++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
@@ -824,6 +824,7 @@ static const struct panfrost_compatible
mediatek_mt8188_data = {
.num_pm_domains = ARRAY_SIZE(mediatek_mt8183_pm_domains),
.pm_domain_names = mediatek_mt8183_pm_domains,
.pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF),
+ .gpu_configs = BIT(GPU_CONFIG_AARCH64_4K),
};
static const char * const mediatek_mt8192_supplies[] = { "mali",
NULL };
Didn't that work on MT8195/8395 as well? I also recall hearing that it
was somewhat
giving ever-so-slightly better performance?
Running glmark2-es2-drm [0] benchmark, reported the same performance
("glmark2 Score") on both configurations, before and after this
patchset. Tested on a Mediatek Genio 1200 EVK board.
To avoid holding this longer, I'll add it to patchset v2, and let's
continue discussion there in any case.
[0] https://github.com/glmark2/glmark2
If it does, please enable it on 8195 as well :-)
also s/mediatek_mt8188/MediaTek MT8188/g
Ack.
...and btw
Reviewed-by: AngeloGioacchino Del Regno
<angelogioacchino.delregno@xxxxxxxxxxxxx>
Thanks!
--
Ariel D'Alessandro
Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718
