On Fri, Mar 14, 2025 at 11:38:40AM +0800, Andy Yan wrote: > From: Andy Yan <andy.yan@xxxxxxxxxxxxxx> > > The helper functions drm_dp_link_power_up/down were moved to Tegra > DRM at 2019[0]. Just mention commit here like "in the commit 9a42c7c647a9 ("drm/tegra: Move drm_dp_link helpers to Tegra DRM")" > > Now since more and more users are duplicating the same code in their > own drivers, it's time to make them as DRM DP common helpers again. > > [0]https://patchwork.freedesktop.org/patch/336850/?series=68031&rev=3 I'd say, drop it, please. With the commit message fixed: Acked-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx> > Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx> > --- > > drivers/gpu/drm/display/drm_dp_helper.c | 69 +++++++++++++++++++++++++ > drivers/gpu/drm/tegra/dp.c | 67 ------------------------ > drivers/gpu/drm/tegra/dp.h | 2 - > drivers/gpu/drm/tegra/sor.c | 4 +- > include/drm/display/drm_dp_helper.h | 2 + > 5 files changed, 73 insertions(+), 71 deletions(-) > -- With best wishes Dmitry