Hello Thomas,
On Thu, 13 Mar 2025 15:40:43 +0100
Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
> > @@ -365,9 +365,10 @@ static int mxsfb_probe(struct platform_device *pdev)
> > * located anywhere in RAM
> > */
> > ret = aperture_remove_all_conflicting_devices(mxsfb_driver.name);
> > - if (ret)
> > - return dev_err_probe(&pdev->dev, ret,
> > - "can't kick out existing framebuffers\n");
> > + if (ret) {
> > + dev_err_probe(&pdev->dev, ret, "can't kick out existing framebuffers\n");
> > + goto err_unload;
> > + }
>
> I must have missed that when I reviewed the patch. But this call should
> happen much earlier. right at the top of the probe function before
> drm_dev_alloc(). Conflicting drivers need to be kicked out before
> setting up DRM. Could you please send a patch to move the call to the
> top? No extra cleanup would be required then.
Sure, sending v2 in a moment.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
