Re: [PATCH 2/3] drm/udl: Switch poll helpers to managed cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 3, 2025 at 4:00 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
>
> Call drmm_kms_helper_poll_init() to set up managed cleanup for
> connector polling.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>

> ---
>  drivers/gpu/drm/udl/udl_drv.c     | 1 -
>  drivers/gpu/drm/udl/udl_main.c    | 2 --
>  drivers/gpu/drm/udl/udl_modeset.c | 1 +
>  3 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
> index 7e7d704be0c0..29f34b4a732d 100644
> --- a/drivers/gpu/drm/udl/udl_drv.c
> +++ b/drivers/gpu/drm/udl/udl_drv.c
> @@ -128,7 +128,6 @@ static void udl_usb_disconnect(struct usb_interface *interface)
>         struct drm_device *dev = usb_get_intfdata(interface);
>
>         drm_dev_unplug(dev);
> -       drm_kms_helper_poll_fini(dev);
>         udl_drop_usb(dev);
>  }
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index 3ebe2ce55dfd..a76b8f57917e 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -336,8 +336,6 @@ int udl_init(struct udl_device *udl)
>         if (ret)
>                 goto err;
>
> -       drm_kms_helper_poll_init(dev);
> -
>         return 0;
>
>  err:
> diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
> index bbb04f98886a..3b65e93ea0ae 100644
> --- a/drivers/gpu/drm/udl/udl_modeset.c
> +++ b/drivers/gpu/drm/udl/udl_modeset.c
> @@ -535,6 +535,7 @@ int udl_modeset_init(struct drm_device *dev)
>                 return ret;
>
>         drm_mode_config_reset(dev);
> +       drmm_kms_helper_poll_init(dev);
>
>         return 0;
>  }
> --
> 2.48.1
>




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux