On Mon, 10 Mar 2025 21:19:03 -0400 "Martin K. Petersen" <martin.petersen@xxxxxxxxxx> wrote: > On Tue, 25 Feb 2025 20:17:14 +0000, Easwar Hariharan wrote: > > > This is the second series (part 1*) that converts users of msecs_to_jiffies() that > > either use the multiply pattern of either of: > > - msecs_to_jiffies(N*1000) or > > - msecs_to_jiffies(N*MSEC_PER_SEC) > > > > where N is a constant or an expression, to avoid the multiplication. > > > > [...] > > Applied to 6.15/scsi-queue, thanks! > > [02/16] scsi: lpfc: convert timeouts to secs_to_jiffies() > https://git.kernel.org/mkp/scsi/c/a131f20804d6 Really, an acked-by would have been much easier all around, but whatever. Did you get my fix? From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: scsi-lpfc-convert-timeouts-to-secs_to_jiffies-fix Date: Tue Feb 25 07:32:03 PM PST 2025 fix build Cc: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx> Cc: James Bottomley <james.bottomley@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/scsi/lpfc/lpfc_sli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/lpfc/lpfc_sli.c~scsi-lpfc-convert-timeouts-to-secs_to_jiffies-fix +++ a/drivers/scsi/lpfc/lpfc_sli.c @@ -3954,7 +3954,7 @@ void lpfc_poll_eratt(struct timer_list * else /* Restart the timer for next eratt poll */ mod_timer(&phba->eratt_poll, - jiffies + secs_to_jiffies(phba->eratt_poll_interval); + jiffies + secs_to_jiffies(phba->eratt_poll_interval)); return; } _