On Fri, Mar 7, 2025 at 11:09 PM Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Fri, Mar 07, 2025 at 09:40:56PM -0600, Rob Herring (Arm) wrote: > > > > On Sat, 08 Mar 2025 03:42:23 +0200, Dmitry Baryshkov wrote: > > > From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > > > Describe the Mobile Display SubSystem (MDSS) device present on the > > > Qualcomm SAR2130P platform. It looks pretty close to SM8550 on the > > > system level. SAR2130P features two DSI hosts and single DisplayPort > > > controller. > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > --- > > > .../bindings/display/msm/qcom,sar2130p-mdss.yaml | 445 +++++++++++++++++++++ > > > 1 file changed, 445 insertions(+) > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sar2130p-mdss.example.dtb: dsi@ae94000: compatible: 'oneOf' conditional failed, one must be fixed: > > ['qcom,sar2130p-dsi-ctrl', 'qcom,mdss-dsi-ctrl'] is too long > > 'qcom,sar2130p-dsi-ctrl' is not one of ['qcom,apq8064-dsi-ctrl', 'qcom,msm8226-dsi-ctrl', 'qcom,msm8916-dsi-ctrl', 'qcom,msm8953-dsi-ctrl', 'qcom,msm8974-dsi-ctrl', 'qcom,msm8976-dsi-ctrl', 'qcom,msm8996-dsi-ctrl', 'qcom,msm8998-dsi-ctrl', 'qcom,qcm2290-dsi-ctrl', 'qcom,sc7180-dsi-ctrl', 'qcom,sc7280-dsi-ctrl', 'qcom,sdm660-dsi-ctrl', 'qcom,sdm670-dsi-ctrl', 'qcom,sdm845-dsi-ctrl', 'qcom,sm6115-dsi-ctrl', 'qcom,sm6125-dsi-ctrl', 'qcom,sm6150-dsi-ctrl', 'qcom,sm6350-dsi-ctrl', 'qcom,sm6375-dsi-ctrl', 'qcom,sm7150-dsi-ctrl', 'qcom,sm8150-dsi-ctrl', 'qcom,sm8250-dsi-ctrl', 'qcom,sm8350-dsi-ctrl', 'qcom,sm8450-dsi-ctrl', 'qcom,sm8550-dsi-ctrl', 'qcom,sm8650-dsi-ctrl'] > > 'qcom,sar2130p-dsi-ctrl' is not one of ['qcom,dsi-ctrl-6g-qcm2290', 'qcom,mdss-dsi-ctrl'] > > from schema $id: http://devicetree.org/schemas/display/msm/dsi-controller-main.yaml# > > It looks like the patch 2 could not be applied and was skipped. Is the > bot parsing the dependencies from the cover letter? No, it's not that smart. I need to move it to using b4 though that has its own quirks when no dependencies are given. Rob