Hi Jonathan, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Cavitt/drm-xe-xe_gt_pagefault-Disallow-writes-to-read-only-VMAs/20250308-064247 base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next patch link: https://lore.kernel.org/r/20250307224125.111430-7-jonathan.cavitt%40intel.com patch subject: [PATCH v6 6/6] drm/xe/xe_vm: Implement xe_vm_get_faults_ioctl config: i386-randconfig-141-20250309 (https://download.01.org/0day-ci/archive/20250309/202503091053.Hg9hUB8c-lkp@xxxxxxxxx/config) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202503091053.Hg9hUB8c-lkp@xxxxxxxxx/ New smatch warnings: drivers/gpu/drm/xe/xe_vm.c:3557 fill_faults() warn: iterator 'i' not incremented vim +/i +3557 drivers/gpu/drm/xe/xe_vm.c 24e54814071dd04 Jonathan Cavitt 2025-03-07 3552 static int fill_faults(struct xe_vm *vm, 24e54814071dd04 Jonathan Cavitt 2025-03-07 3553 struct drm_xe_vm_get_faults *args) 24e54814071dd04 Jonathan Cavitt 2025-03-07 3554 { 24e54814071dd04 Jonathan Cavitt 2025-03-07 3555 struct xe_vm_fault __user *usr_ptr = u64_to_user_ptr(args->faults); 24e54814071dd04 Jonathan Cavitt 2025-03-07 3556 struct xe_vm_pf_entry *entry; 24e54814071dd04 Jonathan Cavitt 2025-03-07 @3557 int ret = 0, i = 0; 24e54814071dd04 Jonathan Cavitt 2025-03-07 3558 24e54814071dd04 Jonathan Cavitt 2025-03-07 3559 spin_lock(&vm->pfs.lock); 24e54814071dd04 Jonathan Cavitt 2025-03-07 3560 list_for_each_entry(entry, &vm->pfs.list, list) { 24e54814071dd04 Jonathan Cavitt 2025-03-07 3561 struct xe_pagefault *pf = entry->pf; 24e54814071dd04 Jonathan Cavitt 2025-03-07 3562 24e54814071dd04 Jonathan Cavitt 2025-03-07 3563 ret = put_user(pf->page_addr, &usr_ptr->address); 24e54814071dd04 Jonathan Cavitt 2025-03-07 3564 if (ret) 24e54814071dd04 Jonathan Cavitt 2025-03-07 3565 break; 24e54814071dd04 Jonathan Cavitt 2025-03-07 3566 24e54814071dd04 Jonathan Cavitt 2025-03-07 3567 ret = put_user(pf->address_type, &usr_ptr->address_type); 24e54814071dd04 Jonathan Cavitt 2025-03-07 3568 if (ret) 24e54814071dd04 Jonathan Cavitt 2025-03-07 3569 break; 24e54814071dd04 Jonathan Cavitt 2025-03-07 3570 24e54814071dd04 Jonathan Cavitt 2025-03-07 3571 ret = put_user(1, &usr_ptr->address_precision); 24e54814071dd04 Jonathan Cavitt 2025-03-07 3572 if (ret) 24e54814071dd04 Jonathan Cavitt 2025-03-07 3573 break; 24e54814071dd04 Jonathan Cavitt 2025-03-07 3574 24e54814071dd04 Jonathan Cavitt 2025-03-07 3575 usr_ptr++; 24e54814071dd04 Jonathan Cavitt 2025-03-07 3576 24e54814071dd04 Jonathan Cavitt 2025-03-07 3577 if (i == args->fault_count) if (++i >= args->fault_count) ? 24e54814071dd04 Jonathan Cavitt 2025-03-07 3578 break; 24e54814071dd04 Jonathan Cavitt 2025-03-07 3579 } 24e54814071dd04 Jonathan Cavitt 2025-03-07 3580 spin_unlock(&vm->pfs.lock); 24e54814071dd04 Jonathan Cavitt 2025-03-07 3581 24e54814071dd04 Jonathan Cavitt 2025-03-07 3582 return ret ? -EFAULT : 0; 24e54814071dd04 Jonathan Cavitt 2025-03-07 3583 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
