On Thu, Mar 06, 2025 at 03:04:50PM +0200, Jani Nikula wrote: > On Thu, 06 Mar 2025, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > > On Sat, 01 Mar 2025, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > >> Existing DPCD access functions return an error code or the number of > >> bytes being read / write in case of partial access. However a lot of > >> drivers either (incorrectly) ignore partial access or mishandle error > >> codes. In other cases this results in a boilerplate code which compares > >> returned value with the size. > >> > >> As suggested by Jani implement new set of DPCD access helpers, which > >> ignore partial access, always return 0 or an error code. Reimplement > >> existing helpers using the new functions to ensure backwards > >> compatibility. > > > > I think that description is for earlier versions of the series, it's the > > other way round now. > > > > Regardless, glanced through the series quickly, I like it, this is > > > > Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > PS. If you need to send another round, please Cc: intel-gfx and intel-xe > to run this through CI for both i915 and xe drivers. Thanks! It might be a good idea to do that anyway. I'll send next iteration, fixing the cover letter and adding both MLs. I hope we can tolerate a bit of spam for the sake of getting the series a proper CI test. -- With best wishes Dmitry
