Hi all, On Thu, 6 Mar 2025 at 13:39, Maxime Ripard <mripard@xxxxxxxxxx> wrote: > It looks fairly generic to me. Is there any reason you didn't put it in > the HDMI audio helpers? I originally wrote the downstream patch last year on 6.6, before the generic HDMI audio code existed. I just had a look at doing this. At the moment drm_hdmi_audio_helper doesn't manage the snd_soc_card (needed to setup the jack) at all, that still lives in vc4_hdmi_audio, so I can't see an easy way to move this over without a lot more reorganising. David