On Sat, Feb 1, 2025 at 2:14 AM <linux@xxxxxxxxxxx> wrote: > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx> > > The mrst_helper_funcs const was added in 2013 by > commit ac6113ebb70d ("drm/gma500/mrst: Add SDVO clock calculation") > and commented as 'Not used yet'. > > It's not been used since, so remove it. You talk about mrst_helper_funcs but the patch removes mrst_clock_funcs. I assume this is not intentional. -Patrik > > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx> > --- > drivers/gpu/drm/gma500/oaktrail_crtc.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c > index de8ccfe9890f..ea9b41af0867 100644 > --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c > +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c > @@ -658,10 +658,3 @@ const struct drm_crtc_helper_funcs oaktrail_helper_funcs = { > .prepare = gma_crtc_prepare, > .commit = gma_crtc_commit, > }; > - > -/* Not used yet */ > -const struct gma_clock_funcs mrst_clock_funcs = { > - .clock = mrst_lvds_clock, > - .limit = mrst_limit, > - .pll_is_valid = gma_pll_is_valid, > -}; > -- > 2.48.1 >